On 04/10/2014 03:57 PM, Tomasz Figa wrote:
Hi Daniel,
On 10.04.2014 11:55, Daniel Lezcano wrote:
One more step is moving the clock ratio setting at idle time in pm.c
The macro names have been changed to be consistent with the other macros name in the file.
Note, the clock divider was working only when cpuidle was enabled because it was in its init routine. With this change, the clock divider is set in the pm's init routine, so it will also operate when the cpuidle driver is not set, which is good.
Signed-off-by: Daniel Lezcano daniel.lezcano@linaro.org Reviewed-by: Viresh Kumar viresh.kumar@linaro.org Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnierkie@samsung.com Reviewed-by: Tomasz Figa t.figa@samsung.com
arch/arm/mach-exynos/cpuidle.c | 54
arch/arm/mach-exynos/pm.c | 35 +++++++++++++++++++++++++ arch/arm/mach-exynos/regs-pmu.h | 19 ++++++++++++++ 3 files changed, 54 insertions(+), 54 deletions(-)
Sorry that I didn't mention that before, but now I recall that there was already a similar patch moving this code to Exynos5250 clock driver, which is the best place for setup of any CMU registers and a step towards removing one more static IO mapping.
Yes, Bartlomiej mentioned it.
Is it possible to merge this mentioned patch or to give a pointer to it so I can integrate it into the patchset ?
Also one more thing below.
[ ... ]
{ #ifdef CONFIG_CACHE_L2X0 @@ -244,6 +276,9 @@ static void exynos_pm_resume(void)
s3c_pm_do_restore_core(exynos_core_save,ARRAY_SIZE(exynos_core_save));
- if (soc_is_exynos5250())
exynos5_core_down_clk();Originally this code was executed at system boot-up, but now it is happening on resume from sleep. Is this change desired?
Argh ! Sounds like I got a bad fuzz there.