On 24 September 2014 19:48, Dietmar Eggemann dietmar.eggemann@arm.com wrote:
On 23/09/14 17:08, Vincent Guittot wrote:
[snip]
This review (by PeterZ) during v5 of your patch-set recommended some renaming (e.g. s/group_has_free_capacity/group_has_capacity and s/group_out_of_capacity/group_no_capacity as well as reordering of the parameters which I agree with:
Ah... you're right, these changes have passed through my seance of renaming
-/*
[snip]
if (sgs->group_capacity_factor > sgs->sum_nr_running)sgs->group_has_free_capacity = 1;
sgs->group_type = group_classify(group, sgs, env);sgs->group_out_of_capacity = group_is_overloaded(sgs, env);In case sgs->group_type is group_overloaded you could set sgs->group_out_of_capacity to 1 without calling group_is_overloaded again.
I prefer to keep sgs->group_out_of_capacity = group_is_overloaded(sgs, env) and use it in group_classify in case of future changes in the classification order
Regards, Vincent
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 7cdf271e8e52..52d441c92a4f 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -6037,7 +6037,8 @@ static inline void update_sg_lb_stats(struct lb_env *env,
sgs->group_type = group_classify(group, sgs, env);
sgs->group_out_of_capacity = group_is_overloaded(sgs, env);
if (sgs->group_type == group_overloaded)sgs->group_out_of_capacity = 1;}
}
/** @@ -6198,17 +6163,21 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd
[...]