On 16 April 2015 at 19:50, Scott Bambrough scott.bambrough@linaro.org wrote:
I have a question:
The following fragment from arch/arm64/kernel/topology.c prints an error for all CPU's on the HiKey.
rate = of_get_property(cn, "clock-frequency", &len); if (!rate || len != 4) { pr_err("%s: Missing clock-frequency property\n", cn->full_name); continue; }
This doesn't seem to be fatal, and Juno and other platforms do not seem to have it set. If that is the case, why is it an error, rather than a warning? Also if no one uses it why check for it at all? Backwards compatibility with other architectures?
Git blame says the code is from:
9d3630b3919954ad100ce155cc8cbdd7f0729600 Author: Mark Brown broonie@linaro.org arm64: topology: Tell the scheduler about the relative power of cores
Similar patch doesn't appear in mainline, so I think no point worrying about it. Probably related to the big.LITTLE code in linux-linaro.
Riku