Re: [PATCH 02/34] cpufreq: acpi: remove calls to cpufreq_notify_transition()

On 16 August 2013 13:24, Lan Tianyu lantianyu1986@gmail.com wrote:

Sorry for misoperation.

No Problem...

            One concern. Target() callback may return before changing

cpufreq actually due to some check failures. After this change, prechange event will be triggered when these check failures take place. I am not sure whether this should be took into account.

Yes, if you see the first patch of this series, it takes this into account.. In case target() failed and returned an error, we simply notify the POST CHANGE notification with old frequencies instead of new ones. I believe that would be enough..

This is exactly what acpi-cpufreq and others are doing currently.

Hope I answered your question well?

-- viresh