9 Oct
2014
9 Oct
'14
3:18 p.m.
On Thu, Oct 09, 2014 at 04:18:02PM +0200, Vincent Guittot wrote:
On 9 October 2014 14:16, Peter Zijlstra peterz@infradead.org wrote:
On Tue, Oct 07, 2014 at 02:13:36PM +0200, Vincent Guittot wrote:
+static inline bool +group_has_capacity(struct lb_env *env, struct sg_lb_stats *sgs) {
if ((sgs->group_capacity * 100) >(sgs->group_usage * env->sd->imbalance_pct))return true;Why the imb_pct there? We're looking for 100% utilization, not 130 or whatnot, right?
Having exactly 100% is quite difficult because of various rounding. So i have added a margin/threshold to prevent any excessive change of the state. I have just to use the same margin/threshold than in other place in load balance.
Yet you failed to mention this anywhere. Also does it really matter?