Re: Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL)

On 03-08-15, 05:10, MyungJoo Ham wrote:

...

...

IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it.

Signed-off-by: Viresh Kumar viresh.kumar@linaro.org

@ from include/linux/err.h #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO) ... static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr) { return !ptr || IS_ERR_VALUE((unsigned long)ptr); }

"!ptr" appears not covered with IS_ERR_OR_NULL. (only the IS_ERR part seems covered)

Right, the first patch of the series has fixed that.

http://permalink.gmane.org/gmane.linux.kernel/2009151

Ah.. ok, then,

Acked-by: MyungJoo Ham myungjoo.ham@samsung.com

please let me know when the series is ready to go.

Cheers, MyungJoo

-- viresh