On 10/19/2013 10:02 PM, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
Currently the imx DMA code is one of the few users relying on the fact that the compat code uses the dma_data as the filter data for non-DT channel requests. Since the rest of the core expects this to be a struct snd_dmaengine_dai_data this isn't terribly helpful this will be changed to use the already existing filter data so avoid breaking imx by open coding the current behaviour.
Signed-off-by: Mark Brown broonie@linaro.org
Since the driver is already using the generic struct adding this to the other patch makes more sense to me:
--- a/sound/soc/fsl/imx-pcm-dma.c +++ b/sound/soc/fsl/imx-pcm-dma.c @@ -25,12 +25,10 @@
static bool filter(struct dma_chan *chan, void *param) { - struct snd_dmaengine_dai_dma_data *dma_data = param; - if (!imx_dma_is_general_purpose(chan)) return false;
- chan->private = dma_data->filter_data; + chan->private = param;
return true; }