On 12 February 2015 at 16:00, skannan@codeaurora.org wrote:
I think for logical hotplug we should lock the governor from being
Nack.
removed. Or, if you don't want that, go set the pointer to NULL lazily when/if that happens.
That would be another band-aid ..
I'm not sure if you read rest of my email. Unless you added some patches
I did read them..
recently, restoring the last_governor is definitely functionally broken as of at least 3.12. Probably 3.14 too (I need to check again). It just restores the governor with the default tunables. So, it's kinda useless in the real world. You might as well set it to default governor because it's just as helpful as using the last governor with different tunables.
I agree that the tunables aren't restored, but this is useful atleast for the case where the governor tunables are shared across policies. And so we don't have to change the tunables on policy-re-init..
This patch wasn't about changing the functionality but about saving some memory and simple code flow..