Re: [PATCH 2/2] tick: SHUTDOWN event-dev if no events are required for KTIME_MAX

On Mon, 12 May 2014, Viresh Kumar wrote:

On 10 May 2014 16:31, Thomas Gleixner tglx@linutronix.de wrote:

...

There is even a better way to do that:

1. Create a new callback set_state() which has an int return value.

2. Make the callsites do

   if (dev->set_state) { ret = dev->set_state(); handle_return_value(); } else dev->set_mode();

Do you want me to touch clock_event_mode as well? Otherwise we will pass mode into a function setting state..

Or we can do s/mode/state after all the work suggested by you is done ..

Or leave as is..

You can name the new callback set_dev_mode() :)

set_state() was just pulled out of the air for illustration.

Thanks,

tglx