Re: [PATCH 06/14] cpufreq: cpu0: defer probe if clock isn't registered yet

On 07/02/14 04:32, Viresh Kumar wrote:

diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c index 4273a5f..0c16b2f 100644 --- a/drivers/cpufreq/cpufreq-cpu0.c +++ b/drivers/cpufreq/cpufreq-cpu0.c @@ -151,7 +151,16 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev) cpu_clk = clk_get(cpu_dev, NULL); if (IS_ERR(cpu_clk)) { ret = PTR_ERR(cpu_clk);

•           pr_err("failed to get cpu0 clock: %d\n", ret);
  

•           /*
  

•            * If cpu's clk node is present, but clock is not yet
  

•            * registered, we should try defering probe.
  

•            */
  

•           if (ret == -EPROBE_DEFER)
  

•                   dev_err(cpu_dev, "cpu0 clock not ready, retry\n");
  

Please make this a dev_dbg() or just remove it entirely. Sending a message to the log on probe defer just duplicates what the driver core is already doing.