On Tue, May 08, 2012 at 10:36:31AM +0300, Pekka Enberg wrote: [...]
- VMEVENT_ATTR_STATE_ONE_SHOT is misleading name. That is effect as
edge trigger shot. not only once.
Would VMEVENT_ATTR_STATE_EDGE_TRIGGER be a better name?
[...]
- Currently, vmstat have per-cpu batch and vmstat updating makes 3
second delay at maximum. This is fine for usual case because almost userland watcher only read /proc/vmstat per second. But, for vmevent_fd() case, 3 seconds may be unacceptable delay. At worst, 128 batch x 4096 x 4k pagesize = 2G bytes inaccurate is there.
That's pretty awful. Anton, Leonid, comments?
[...]
- __VMEVENT_ATTR_STATE_VALUE_WAS_LT should be removed from userland
exporting files. When exporing kenrel internal, always silly gus used them and made unhappy.
Agreed. Anton, care to cook up a patch to do that?
KOSAKI-San, Pekka,
Much thanks for your reviews!
These three issues should be fixed by the following patches. One mm/ change is needed outside of vmevent...
And I'm looking into other issues you pointed out...
Thanks!
--- include/linux/vmevent.h | 10 +++---- include/linux/vmstat.h | 2 ++ mm/vmevent.c | 66 +++++++++++++++++++++++++++++------------------ mm/vmstat.c | 22 +++++++++++++++- 4 files changed, 68 insertions(+), 32 deletions(-)