On Tue, Apr 21, 2015 at 2:28 AM, Paul Bolle pebolle@tiscali.nl wrote:
On Mon, 2015-04-20 at 17:27 +0800, pi-cheng.chen wrote:
--- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm
+config ARM_MT8173_CPUFREQ
bool "Mediatek MT8173 CPUFreq support"depends on ARCH_MEDIATEK && REGULATORhelpThis adds the CPUFreq driver support for Mediatek MT8173 SoC.--- a/drivers/cpufreq/Makefile +++ b/drivers/cpufreq/Makefile
+obj-$(CONFIG_ARM_MT8173_CPUFREQ) += mt8173-cpufreq.o
ARM_MT8173_CPUFREQ is a bool symbol, so mt8173-cpufreq.o will never be part of a module.
(If that's incorrect you can stop reading here.)
--- /dev/null +++ b/drivers/cpufreq/mt8173-cpufreq.c
+#include <linux/module.h>
I guess this include is not needed. And, for what it's worth, make ARCH=arm CROSS_COMPILE=arm-linux-gnu- drivers/cpufreq/mt8173-cpufreq.o
compiles silently even if it's dropped.
+module_init(mt8173_cpufreq_driver_init);
According to include/linux/init.h, for built-in only code, this is equivalent to device_initcall([...]). And two runs of make ARCH=arm CROSS_COMPILE=arm-linux-gnu- drivers/cpufreq/mt8173-cpufreq.i
confirm that.
Hi Paul,
Thanks for your reviewing. The <linux/module.h> is not needed here. I'll remove it.
Best Regards, Pi-Cheng
Thanks,
Paul Bolle