Re: [PATCH 189/228] cpufreq: dbx500: remove calls to cpufreq_notify_transition()

On Fri, Sep 13, 2013 at 3:02 PM, Viresh Kumar viresh.kumar@linaro.org wrote:

Most of the drivers do following in their ->target_index() routines:

    struct cpufreq_freqs freqs;
    freqs.old = old freq...
    freqs.new = new freq...

    cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE);

    /* Change rate here */

    cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);

This is replicated over all cpufreq drivers today and there doesn't exists a good enough reason why this shouldn't be moved to cpufreq core instead.

Earlier patches have added support in cpufreq core to do cpufreq notification on frequency change, this one removes it from this driver.

Some related minor cleanups are also done along with it.

Cc: Linus Walleij linus.walleij@linaro.org Signed-off-by: Viresh Kumar viresh.kumar@linaro.org

Acked-by: Linus Walleij linus.walleij@linaro.org

Yours, Linus Walleij