Re: HMP Idle Pull Bug 1301886

On Thu, 2014-05-01 at 13:59 +0100, Chris Redpath wrote: [...]

Changing the BUG to a simple return NULL and fixing up the callers for this case as you did in your testing patch is functionally correct and safe. The question for me is if we should bother to try to optimize idle_pull behavior during cpu_down - I'm open to opinions :)

My opinion is 'no', because unless I missed something, this case shouldn't really occur much or at all during normal use. If it did, surely you would have hit the BUG_ON before. ;-)

Or does cpuidle hit this CPUs offlining case? (I'm a bit fuzzy on these things, but I would have thought not).