On Tuesday 11 March 2014 09:46:41 Liviu Dudau wrote:
On Tue, Mar 11, 2014 at 06:50:24AM +0000, Arnd Bergmann wrote:
On Monday 10 March 2014 21:56:00 Liviu Dudau wrote:
PCI_IOBASE is always defined. See the discussion with Russell on this subject.
include/asm-generic/io.h has at line 118:
#ifndef PCI_IOBASE #define PCI_IOBASE ((void __iomem *) 0) #endif
That is only defined for those that use asm-generic/pci.h, which most architectures don't.
I think it is defined for anyone that #includes <asm-generic/io.h>. There is no other #ifdef around that.
My mistake, I meant to write asm-generic/io.h.
On a related note, I would actually prefer to get rid of this PCI_IOBASE default and move it into the architectures that really want it like this. The default when PCI_IOBASE is not set IMHO should be to also not provide inb/outb and ioport_map() helpers, but we need a little more infrastructure to actually make the kernel build in all valid configuration when we remove them.
Arnd