On 1/6/2014 8:33 AM, Peter Zijlstra wrote:
On Wed, Jan 01, 2014 at 10:30:33AM +0530, Preeti U Murthy wrote:
The design looks good to me. In my opinion information like P-states and C-states dependency can be kept separate from the topology levels, it might get too complicated unless the information is tightly coupled to the topology.
I'm not entirely convinced we can keep them separated, the moment we have multiple CPUs sharing a P or C state we need somewhere to manage the shared state and the domain tree seems like the most natural place for this.
Now it might well be both P and C states operate at 'natural' domains which we already have so it might be 'easy'.
more than that though.. P and C state sharing is mostly hidden from the OS (because the OS does not have the ability to do this; e.g. there are things that do "if THIS cpu goes idle, the OTHER cpu P state changes automatic".
that's not just on x86, the ARM guys (iirc at least the latest snapdragon) are going in that direction as well.....
for those systems, the OS really should just make local decisions and let the hardware cope with hardware grouping.