26 Jun
2014
26 Jun
'14
7:34 a.m.
On 26 June 2014 00:32, Stephen Boyd sboyd@codeaurora.org wrote:
cpu_reg = regulator_get_optional(cpu_dev, "cpu0");
I don't think this driver should be using regulator_get_optional() (Mark B. please correct me if I'm wrong). I doubt a supply is actually optional for CPUs, just some DTs aren't specifying them. In those cases, the regulator core will insert a dummy supply and the code will work without having to check for probe defer and error pointers.
This is what Mark did earlier, don't know if he would like to revert it: 7d74897 (cpufreq: cpufreq-cpu0: Use devm_regulator_get_optional()).