On 21 May 2014 15:18, Sudeep Holla sudeep.holla@arm.com wrote:
Why do we need to return anything? Let that function have return type 'void'?
Hmm, don't we still need to throw error if DT has invalid OPP ? It doesn't may sense to me if no errors is returned and still CPUFreq fails later.
I wasn't sure if we should fail CPU's registration if it had bad OPPs. Maybe just print a good message and go ahead. CPU is usable atleast :)
Also would it make sense to move this into it as well?
cpu->dev.of_node = of_get_cpu_node(num, NULL);
I don't quite understand what you mean here ?
This piece of code was added by you earlier to register_cpu(). As this was also DT specific, should I move this as well to the new routine we are creating?