Re: [PATCH 1/6] PM / OPP: reuse of_parse_phandle()

On 08/11, Viresh Kumar wrote:

On 10-08-15, 23:02, Stephen Boyd wrote:

...

...

• if (prop->length != sizeof(__be32)) {

• dev_err(dev, "%s: Invalid opp desc phandle\n", __func__);
  

• return ERR_PTR(-EINVAL);
  

• }

But we lost this check? Perhaps we can use of_count_phandle_with_args() to make suer we only have one phandle?

I thought about it earlier and it looked like we don't need to care about this. Even if the user passes multiple strings here, its his problem. We will just pick the first entry and parse it.

And that's true until the point we support multiple table entries, ofcourse :)

Ok. That's worth a mention in the commit text please.