Re: [PATCH 2/3] sched: don't call get_group() for covered cpus

On Tue, Jun 11, 2013 at 04:32:44PM +0530, Viresh Kumar wrote:

In build_sched_groups() we don't need to call get_group() for cpus which are already covered in previous iterations. So, call get_group() after checking if cpu is covered or not.

Aside from not needing it; doing it would mark the group used and eventually leak it since we wouldn't connect it and not find it again to free it, right?

So effectively this fixes a memory leak?

Signed-off-by: Viresh Kumar viresh.kumar@linaro.org

kernel/sched/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 4abc743..27842f5 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5344,12 +5344,12 @@ build_sched_groups(struct sched_domain *sd, int cpu) for_each_cpu(i, span) { struct sched_group *sg;

• int group = get_group(i, sdd, &sg);
  

• int j;
  

• int group, j;
  

if (cpumask_test_cpu(i, covered)) continue;

• group = get_group(i, sdd, &sg);
  

  cpumask_clear(sched_group_cpus(sg)); sg->sgp->power = 0; cpumask_setall(sched_group_mask(sg));

-- 1.7.12.rc2.18.g61b472e