On Fri, Mar 21, 2014 at 03:01:18PM +0000, Catalin Marinas wrote:
On Fri, Mar 21, 2014 at 11:13:53AM +0000, Mark Brown wrote:
One thing that occurs to me with this - if we've always got a DT even if we are booting with ACPI that might confuse code that implements handling for firmware idioms.
The DT presented on an ACPI-capable system only contains the chosen node (I guess the DT will not even be unflattened) .So the topology code would check for DT, if not it would check for ACPI (or the other way around) and only after that fall back to hardware MPIDR. I'm not sure whether current ACPI gives us rich enough information about topology like DT, in which case it could simply use MPIDR.
Sorry, this isn't related to topology - it's to do with other code that checks if a DT was present and makes decisions based on that. So long as of_have_populated_dt() doesn't report true things should be fine but it's something to watch out for.