The size of the struct tegra_powergate is quite big and if any more fields are added to the internal genpd structure, following warnings are thrown:
drivers/soc/tegra/pmc.c:577:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=]
Avoid such warnings by allocating the structure dynamically.
Signed-off-by: Viresh Kumar viresh.kumar@linaro.org --- drivers/soc/tegra/pmc.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index e233dd5dcab3..c94196b939a4 100644 --- a/drivers/soc/tegra/pmc.c +++ b/drivers/soc/tegra/pmc.c @@ -557,22 +557,28 @@ EXPORT_SYMBOL(tegra_powergate_remove_clamping); int tegra_powergate_sequence_power_up(unsigned int id, struct clk *clk, struct reset_control *rst) { - struct tegra_powergate pg; + struct tegra_powergate *pg; int err;
if (!tegra_powergate_is_available(id)) return -EINVAL;
- pg.id = id; - pg.clks = &clk; - pg.num_clks = 1; - pg.resets = &rst; - pg.num_resets = 1; + pg = kzalloc(sizeof(*pg), GFP_KERNEL); + if (!pg) + return -ENOMEM; + + pg->id = id; + pg->clks = &clk; + pg->num_clks = 1; + pg->resets = &rst; + pg->num_resets = 1;
- err = tegra_powergate_power_up(&pg, false); + err = tegra_powergate_power_up(pg, false); if (err) pr_err("failed to turn on partition %d: %d\n", id, err);
+ kfree(pg); + return err; } EXPORT_SYMBOL(tegra_powergate_sequence_power_up);