Re: [PATCH] arm64: bpf: fix JIT stack setup

On Mon, Nov 9, 2015 at 10:08 AM, Shi, Yang yang.shi@linaro.org wrote:

I added it to stay align with ARMv8 AAPCS to maintain the correct FP during function call. It makes us get correct stack backtrace.

I think we'd better to keep compliant with ARMv8 AAPCS in BPF JIT prologue too.

If nobody thinks it is necessary, we definitely could remove that change.

Oh no, I don't think anyone will say it's unnecessary! I agree the A64_FP-related change is a good idea, so stack unwinding works.

How about splitting this into two patches? One for the BPF-related bug, and another for A64 FP-handling.

Thanks again for tracking this down and improving things overall for arm64 :)

Thanks, Yang