On 19 May 2014 22:02, Viresh Kumar viresh.kumar@linaro.org wrote:
Please update the caller function header description. It assumes that will return -ETIME on error. Did you check the impact regarding the new error
I haven't checked yet. Will look into it.
Okay. Thomas has asked me specifically not to do any error handling outside of clockevents_set_mode or __clockevents_update_freq and that's why we have a WARN_ON().
None of the callers of clockevents_update_freq() are handling errors yet and it doesn't look like we need to add that as changing to mode: CLOCK_EVT_MODE_PERIODIC can't fail. And a WARN() for that is enough I believe.
So, I believe I have addressed all your comments and probably don't require any more modifications in this patch atleast ?
-- viresh