On 02/24/2014 10:02 PM, Morten Rasmussen wrote:
Could be weighted_cpuload() instead, but you would have to keep the lines you delete below.
On current logical target_load may seek before, and do bias when idx is busy or idle. I am afraid weighted_cpuload is not good here. and I prefer to keep bias in a uniform mode, not spread in larger scope.
Right, using weighted_cpuload() here would remove the local group versus other group biasing completely. The new bias is different from the existing one though. You have already discarded the bias from source_load(). The new bias is just a scaling factor, so it isn't exactly comparable to the existing one.
Now that source_load() is gone, would it then make sense to rename target_load() to biased_load() or something?
Yes, I did think about this change. But just afraid it has no much sense.
Anyway since you said so. will send out another version. :)