Re: [PATCH 1/3] timer: Allocate per-cpu tvec_base's statically

On 31 March 2015 at 13:15, Ingo Molnar mingo@kernel.org wrote:

• Viresh Kumar viresh.kumar@linaro.org wrote:

...

From: Peter Zijlstra peterz@infradead.org

...

•         if (!boot_done) {
  

•                 boot_done = 1; /* skip the boot cpu */
  

So it would be a lot more descriptive to name this flag 'boot_cpu_skipped'?

Yes.

Also, I'd put a description about the PER_CPU background into comments as well, because it's not obvious at first sight at all what the whole (boot_tvec_bases, tvec_bases, __tvec_bases) dance does.

Yeah, so I did that with a one liner in the last patch, but that doesn't look good enough. I will try to do something better in V2.

Thanks for your reviews.