Re: [PATCH] devfreq: exynos: Don't use OPP structures outside of RCU locks

Hi Viresh,

On 2016년 12월 01일 19:25, Viresh Kumar wrote:

The OPP structures are abused to the best here, without understanding how the OPP core and RCU locks work.

In short, the OPP pointer saved 'struct exynos_bus' can become invalid under your nose, as the OPP core may free it.

Fix various abuses around OPP structures and calls.

Compile tested only.

Signed-off-by: Viresh Kumar viresh.kumar@linaro.org

I would like it to go via the PM tree. Perhaps that's already the default tree for this.

drivers/devfreq/exynos-bus.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-)

Looks good to me and I tested this patch on Exynos4412-odroidu3/Exynos5433-TM2.

Acked-by: Chanwoo Choi cw00.choi@samsung.com Tested-by: Chanwoo Choi cw00.choi@samsung.com