On 14-09-15, 17:25, Arnd Bergmann wrote:
I'd say that the argument to debugfs_create_bool() has to match the access in the functions you are modifying, as well as whatever gets passed into it by callers.
By accessing only the first byte, you break all drivers that call debugfs_create_bool() with a four-byte argument, at least on big-endian systems!
If we change any part of this, we need to audit the existing 31 callers of the function and change them all to use a bool type.
Right, so I have already sent a new version of this patch which should be able to take care of stuff you pointed out.
In the problem that you saw, what prevented gcc from printing a compile-time warning about debugfs_create_bool() being called with a bool argument?
A forced cast to u32 * :)