Re: [PATCH] ASoC: dapm: Don't create routes when creating kcontrols

On 08/13/2013 12:38 AM, Mark Brown wrote:

From: Mark Brown broonie@linaro.org

Attempting to create the route as part of adding a mux control causes us to attempt to add the same route twice since we loop over all sources for the mux after creating the control. Instead do the addition in the callers.

Signed-off-by: Mark Brown broonie@linaro.org

Acked-by: Lars-Peter Clausen lars@metafoo.de

Thanks.

[...]

@@ -821,7 +822,7 @@ static int dapm_new_mux(struct snd_soc_dapm_widget *w) path = list_first_entry(&w->sources, struct snd_soc_dapm_path, list_sink);

The two lines above can also be removed

• ret = dapm_create_or_share_mixmux_kcontrol(w, 0, path);

• ret = dapm_create_or_share_mixmux_kcontrol(w, 0); if (ret < 0) return ret;