Viresh Kumar viresh.kumar@linaro.org writes:
This is my third attempt to migrate clockevent drivers to use set_dev_mode(). I have tried to fix all issues raised by Frederic/Kevin on V2.
Please let me know if I missed something. Though patches 2-7 look big, it should be fairly easy to review them now, so do try that :)
Speaking of ease of review...
In this series, I don't think you should do a wholesale conversion in this series and remove the existing ->set_mode().
I think the goal of this series should be simply the introduction of the new ->set_dev_mode() with its error handling, and the conversion of a handful clockevent devices to use it (IMO, arch/arm/* is a good representation of a variety of clockevent devices.)
Then, pick a clockevent device and implement ONESHOT_STOPPED for it.
You don't need to convert the world and remove the old way quite yet. Let's use this series to demonstrate the idea, showing a few examples, and the new ONESHOT_STOPPED implementation.
That will allow folks to see the whole idea, get a handle on it and allow us to come to agreement on the general approach.
Once there's agreement on the general approach, we can then cleanup the rest of the clockevent devices, convert them to ->set_dev_mode() and remove ->set_mode().
Kevin