Wouldn't it have been better to just revert the patch that added the platform specific pre-processing?
What you are doing now is introducing a second config change into LSK...
The revert would have looked like this:
#ifdef CONFIG_SCHED_HMP_LITTLE_PACKING -#ifndef CONFIG_ARCH_VEXPRESS_TC2 unsigned int hmp_packing_enabled = 1; +#ifndef CONFIG_ARCH_VEXPRESS_TC2 unsigned int hmp_full_threshold = (NICE_0_LOAD * 9) / 8; #else /* TC2 has a sharp consumption curve @ around 800Mhz, so we aim to spread the load around that frequency. */ -unsigned int hmp_packing_enabled; unsigned int hmp_full_threshold = 650; /* 80% of the 800Mhz freq * NICE_0_LOAD */ #endif #endif
Mark
-----Original Message----- From: Jon Medhurst (Tixy) [mailto:tixy@linaro.org] Sent: 01 May 2014 14:37 To: Mark Brown; Alex Shi Cc: Linaro Kernel; Chris Redpath; Robin Randhawa; Mark Hambleton Subject: [PATCH] sched: hmp: Remove compile-time configuration of task packing
Compile-time configuration is messy and precludes multi-platform kernels so remove it. Task packing should instead be tuned at run-time, e.g. in user-side boot scripts, with something like:
echo 1 > /sys/kernel/hmp/packing_enable echo 650 > /sys/kernel/hmp/packing_limit
Signed-off-by: Jon Medhurst tixy@linaro.org
Mark and Alex, please don't apply this directly. Assuming that this change doesn't provoke any dissent, it can be pulled from the usual place... git://git.linaro.org/arm/big.LITTLE/mp.git for-lsk
kernel/sched/fair.c | 7 ------- 1 file changed, 7 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 43857fe..6610622 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3676,15 +3676,8 @@ unsigned int hmp_next_up_threshold = 4096; unsigned int hmp_next_down_threshold = 4096;
#ifdef CONFIG_SCHED_HMP_LITTLE_PACKING -#ifndef CONFIG_ARCH_VEXPRESS_TC2 unsigned int hmp_packing_enabled = 1; unsigned int hmp_full_threshold = (NICE_0_LOAD * 9) / 8; -#else -/* TC2 has a sharp consumption curve @ around 800Mhz, so
- we aim to spread the load around that frequency. */
-unsigned int hmp_packing_enabled; -unsigned int hmp_full_threshold = 650; /* 80% of the 800Mhz freq * NICE_0_LOAD */ -#endif #endif
static unsigned int hmp_up_migration(int cpu, int *target_cpu, struct sched_entity *se); -- 1.7.10.4