Re: [PATCH V2 4/8] PM / OPP: Pass struct dev_pm_opp_supply to _set_opp_voltage()

On 24-10-16, 16:14, Stephen Boyd wrote:

On 10/20, Viresh Kumar wrote:

...

Pass the entire supply structure instead of all of its fields.

Signed-off-by: Viresh Kumar viresh.kumar@linaro.org

This patch should be combined with the previous one.

I think it is a fair to do this separately as this is a completely different logical change.

I'm still not sure if it even makes sense to do this though.

:)

Do we really have to make duplicate "OPP snapshot" structures just because of how OPPs use RCU?

I agree. With RCU, yes this change is probably required. But I am not sure if RCU fits that well to OPP core anymore. A rw-lock may be much easier to help.