On Mon, 2014-03-24 at 16:56 +0000, Chris Redpath wrote:
On 24/03/14 15:33, Jon Medhurst (Tixy) wrote:
On Mon, 2014-03-24 at 13:47 +0000, Chris Redpath wrote:
Hi Tixy, this is the current version with the comments I remember so far.
What's new: Added your build fail fix in patch 2 Removed implicit dependency on CPU_IDLE from patch 3.
Thanks Chris, looks good to me, and I have no more comments on this patch series, well, patch three has a tab in hmp_keepalive_delay() where they should be a space, I'll fix that myself before I apply the patches to the big.LITTLE-MP topic branch.
Are you and Basil OK if these patches go into LSK as they are?
I don't know if Alex has any questions about these patches, he's been a bit quite...?
Hang on Tixy, I didn't notice earlier but that only boots one CPU on my board now..
Will investigate further.
Sure, no rush, let make sure it's right. Though it worked OK for me when I tried it, and I just double checked it again. (I pushed out my test branch to: https://git.linaro.org/people/tixy/kernel.git/shortlog/refs/heads/test-mp-ne...)
And the new patches, apart from the whitespace and a s/inline/static/ were the same as the ones I was testing at the end of last week, on which I ran the functional scheduler tests OK as well as basic manual testing of Android, which included watching the pretty LEDs on TC2 and motherboard to make sure CPU and cluster activity looks sane.