Re: [PATCH 04/10] PM / OPP: Error out on failing to add static OPPs for v1 bindings

On 08-12-16, 14:39, Shawn Guo wrote:

Yes, it's the best effort.

That may get a risky IMO. What if we fail to add all OPPs except the last one, which selects the highest frequency? We will surely overheat most of the SoCs and burn them out.

I think its better to fail and return in such cases.

For example, a duplicated OPP shouldn't be a stopper for the driver.

That's a different case and is already supported properly, as we wouldn't fail in that case.

Thanks for your inputs Shawn.