Re: [PATCH 1/3] tools: timer: add rtctest_setdate

Hi,

On 16/06/2017 at 16:03:51 +0200, Benjamin Gaignard wrote:

This tool allow to set directly the time and date to a RTC device.

Unlike other tools isn't doens't use "strut timeval" or "time_t"

A small typo here-----^

so it is safe for 32bits platforms when testing for y2038/2106 bug.

Signed-off-by: Benjamin Gaignard benjamin.gaignard@linaro.org

tools/testing/selftests/timers/Makefile | 2 +- tools/testing/selftests/timers/rtctest_setdate.c | 86 ++++++++++++++++++++++++ 2 files changed, 87 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/timers/rtctest_setdate.c

diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile index 5fa1d7e9..54481f1 100644 --- a/tools/testing/selftests/timers/Makefile +++ b/tools/testing/selftests/timers/Makefile @@ -9,7 +9,7 @@ TEST_GEN_PROGS = posix_timers nanosleep nsleep-lat set-timer-lat mqueue-lat \ TEST_GEN_PROGS_EXTENDED = alarmtimer-suspend valid-adjtimex adjtick change_skew \ skew_consistency clocksource-switch leap-a-day \

•       leapcrash set-tai set-2038 set-tz
  

•       leapcrash set-tai set-2038 set-tz rtctest_setdate
  

include ../lib.mk diff --git a/tools/testing/selftests/timers/rtctest_setdate.c b/tools/testing/selftests/timers/rtctest_setdate.c new file mode 100644 index 0000000..2cb7848 --- /dev/null +++ b/tools/testing/selftests/timers/rtctest_setdate.c @@ -0,0 +1,86 @@ +/* Real Time Clock Driver Test

• • by: Benjamin Gaignard (benjamin.gaignard@linaro.org)
• • To build
• • gcc rtctest_setdate.c -o rtctest_setdate
• • This program is free software: you can redistribute it and/or modify
• • it under the terms of the GNU General Public License as published by
• • the Free Software Foundation, either version 2 of the License, or
• • (at your option) any later version.
• • This program is distributed in the hope that it will be useful,
• • but WITHOUT ANY WARRANTY; without even the implied warranty of
• • MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
• • GNU General Public License for more details.
• */

+#include <stdio.h> +#include <linux/rtc.h> +#include <sys/ioctl.h> +#include <sys/time.h> +#include <sys/types.h> +#include <fcntl.h> +#include <unistd.h> +#include <stdlib.h> +#include <errno.h>

+static const char default_time[] = "00:00:00";

+int main(int argc, char **argv) +{

• int fd, retval;
• struct rtc_time new, current;
• const char *rtc, *date;
• const char *time = default_time;
• switch (argc) {
• case 4:

• time = argv[3];
  

• /* FALLTHROUGH */
  

• case 3:

• date = argv[2];
  

• rtc = argv[1];
  

• break;
  

• default:

• fprintf(stderr, "usage: rtctest_setdate <rtcdev> <DD-MM-YYYY> [HH:MM:SS]\n");
  

• return 1;
  

• }
• fd = open(rtc, O_RDONLY);
• if (fd == -1) {

• perror(rtc);
  

• exit(errno);
  

• }
• sscanf(date, "%d-%d-%d", &new.tm_mday, &new.tm_mon, &new.tm_year);
• new.tm_mon -= 1;
• new.tm_year -= 1900;
• sscanf(time, "%d:%d:%d", &new.tm_hour, &new.tm_min, &new.tm_sec);
• fprintf(stderr, "Test will set RTC date/time to %d-%d-%d, %02d:%02d:%02d.\n",

• new.tm_mday, new.tm_mon + 1, new.tm_year + 1900,
  

• new.tm_hour, new.tm_min, new.tm_sec);
  

• /* Write the new date in RTC */
• retval = ioctl(fd, RTC_SET_TIME, &new);
• if (retval == -1) {

• perror("RTC_SET_TIME ioctl");
  

• close(fd);
  

• exit(errno);
  

• }
• /* Read back */
• retval = ioctl(fd, RTC_RD_TIME, &current);
• if (retval == -1) {

• perror("RTC_RD_TIME ioctl");
  

• exit(errno);
  

• }
• fprintf(stderr, "\n\nCurrent RTC date/time is %d-%d-%d, %02d:%02d:%02d.\n",

• current.tm_mday, current.tm_mon + 1, current.tm_year + 1900,
  

• current.tm_hour, current.tm_min, current.tm_sec);
  

• close(fd);
• return 0;

+}

1.9.1