Re: [PATCH 06/14] cpufreq: cpu0: defer probe if clock isn't registered yet

On Wednesday 02 July 2014 10:19 PM, Viresh Kumar wrote:

On 3 July 2014 06:08, Stephen Boyd sboyd@codeaurora.org wrote:

...

Please make this a dev_dbg() or just remove it entirely. Sending a message to the log on probe defer just duplicates what the driver core is already doing.

Updated as:

Author: Viresh Kumar viresh.kumar@linaro.org Date: Thu Jun 26 10:40:21 2014 +0530

cpufreq: cpu0: print relevant error when we defer probe

Currently, we defer probe if regulator_get() returned -EPROBE_DEFER, i.e.
regulator isn't registered yet. We do a dev_err() in this case. Sending a
message to the log on probe defer just duplicates what the driver core is
already doing. Convert it to dev_dbg() instead.

We should defer in case of clk_get() as well.

Current code already does it, but it wasn't intentional probably.

Its just that we are returning the right error with wrong print message.

Fix print message to convey right error.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---

drivers/cpufreq/cpufreq-cpu0.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)

Looks good to me. Acked-by: Santosh Shilimkar santosh.shilimkar@ti.com