On 4 June 2014 16:08, Mark Brown broonie@kernel.org wrote:
Please, go and *think* about what's going on here. I've repeatedly asked you to consider the case where we need to raise the voltage prior to raising the frequency for cpufreq but you've not responded to these requests either directly or in showing any sign of having understood the issue.
I replied to that only when I said:
- For platforms with regulators support, we _must_ check if the voltage change is successful or not and fail if regulator_set_voltage() failed.
And what you wrote earlier was correct, we may end up with unstable systems if we ramp frequencies even when changing voltage failed.
If the code fails to change the voltage it needs to handle that (including remembering that attempts to lower the voltage fail); if the code handles the errors sensibly I would expect that to handle everything.
That's what I was asking, how should the code handle it? Code also has to take care of platforms which haven't configured regulators in kernel and want to use this generic driver.
Sorry if I still didn't answer it properly :(