Re: [PATCH 2/6] pstore/ram: Add console messages handling

On Wed, May 16, 2012 at 09:30:52AM -0600, Shuah Khan wrote:

On Wed, 2012-05-16 at 05:56 -0700, Anton Vorontsov wrote:

...

This is all straightforward: we just use the last region for console logging. If there's just one region, we fall-back to the old behaviour: just a oops/dumps logging.

What about the saving /proc/last_kmsg? Are you not bringing that feature from ramconsole? Sorry if I missed it in reading the patches.

Nope, sorry. The /proc/last_kms ABI is just a duplication of pstore's console logging interface, and since last_kmsg thing is in drivers/staging/, there's no point in keeping it, unless there's a really good reason.

Thanks!