Re: [PATCH V2 Resend 2/5] PM / OPP: Prefix exported opp routines with dev_pm_opp_

Hi!

-EXPORT_SYMBOL_GPL(of_cpumask_init_opp_table); +EXPORT_SYMBOL_GPL(dev_pm_opp_cpumask_init_opp);

Well... it starts to be rather long and repetitive.

@@ -237,7 +237,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) * * OPPs might be populated at runtime, don't check for error here */

• of_cpumask_init_opp_table(policy->cpus);

• dev_pm_opp_cpumask_init_opp(policy->cpus);

if (need_update) { struct cpufreq_dt_platform_data *pd = cpufreq_get_driver_data();

...

@@ -356,7 +356,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) out_free_priv: kfree(priv); out_free_opp:

• of_cpumask_free_opp_table(policy->cpus);

• dev_pm_opp_cpumask_free_table(policy->cpus);

out_node_put: of_node_put(np); out_put_reg_clk:

Is ..._free_table opposite of ..._init_opp? If so, you might want to name them such that it is clear...

Thanks, Pavel