On Wed, Jan 08, 2014 at 06:40:21PM +0000, Mark Brown wrote:
On Wed, Jan 08, 2014 at 06:30:06PM +0000, Lorenzo Pieralisi wrote:
On Wed, Jan 08, 2014 at 05:10:10PM +0000, Mark Brown wrote:
+#include <linux/slab.h>
Nitpick, <linux/slab.h> does not belong in this patch. There are other includes that should be moved to the respective patch (percpu.h ?) where they are actually used.
I can move this one but honestly I'm having an extremely difficult time summoning up the enthusiasm for looking for others and moving them - the practical impact will not be substantial.
Ok, it is your call and I understand I am being pedantic but from a logical patch split perspective that's not correct and honestly it should take no more than few minutes to move the includes where they actually belong.
Lorenzo