On 29 March 2014 03:27, Nicolas Pitre nicolas.pitre@linaro.org wrote:
On Fri, 28 Mar 2014, Vincent Guittot wrote:
Part of this patchset was previously part of the larger tasks packing patchset [1]. I have splitted the latter in 3 different patchsets (at least) to make the thing easier. -configuration of sched_domain topology [2] -update and consolidation of cpu_power (this patchset) -tasks packing algorithm
SMT system is no more the only system that can have a CPUs with capacity that is different from the default value. We need to extend the use of cpu_power_orig to all kind of platform so the scheduler will have both the maximum capacity (cpu_power_orig/power_orig) and the current capacity (cpu_power/power) of CPUs and groups of the sched_domains.
[...]
Wouldn't it make sense to have a patch in this series that performs some s/power/capacity/ throughout the scheduler code before the other patches are applied? That would help getting consistent terminology and avoid confusion before real power related metrics are eventually brought into the scheduler.
Fair point. I will add the changes in the next version.
Thanks Vincent
Nicolas