Re: [PATCH] PM / OPP: of_property_count_u32_elems() can return errors

On 17-09-15, 11:13, Stephen Boyd wrote:

...

• count = of_property_count_u32_elems(opp->np, "opp-microvolt");
• if (count < 0) {

We can't test count for -EINVAL to detect the missing property because -EINVAL is also returned on a non-multiple of u32 length property? Maybe we shouldn't worry about that case and turn -EINVAL into 0.

So you are saying that we go ahead without regulators if a incorrect values are present in opp-microvolt? i.e. even if the length property was invalid, we return 0 from this function.

The problem here is that we will try changing the frequency without changing the regulator in that case, and it might not be safe for the platform, isn't it?