Re: [PATCH V2 15/16] cpufreq: dt: drop references to DT node

On 02-02-16, 11:41, Viresh Kumar wrote:

diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c +static const char *find_supply_name(struct device *dev) {

• struct device_node *np; struct property *pp; int cpu = dev->id;
• const char *name = NULL;
• np = of_node_get(dev->of_node);
• if (!np) {

• dev_err(dev, "failed to find cpu%d node\n", cpu);
  

• return ERR_PTR(-ENOENT);
  

• }

I have updated that as:

+ np = of_node_get(dev->of_node); + + /* This must be valid for sure */ + if (WARN_ON(!np)) + return NULL;

so that we don't have to check return value of find_supply_name() for errors, as you pointed out in the other patch.

Will keep your RBY tag :)