Re: [PATCH 1/6] PM / OPP: reuse of_parse_phandle()

On 08/10, Viresh Kumar wrote:

We already have a better API to get the opp descriptor block's node from cpu-node. Lets reuse that instead of creating our own routines for the same stuff. That cleans the code a lot.

Signed-off-by: Viresh Kumar viresh.kumar@linaro.org

Reviewed-by: Stephen Boyd sboyd@codeaurora.org

diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c index 204c6c945168..1daaa1a418a2 100644 --- a/drivers/base/power/opp.c +++ b/drivers/base/power/opp.c /* * TODO: Support for multiple OPP tables. * * There should be only ONE phandle present in "operating-points-v2" * property. */

• if (prop->length != sizeof(__be32)) {

• dev_err(dev, "%s: Invalid opp desc phandle\n", __func__);
  

• return ERR_PTR(-EINVAL);
  

• }

But we lost this check? Perhaps we can use of_count_phandle_with_args() to make suer we only have one phandle?