10 Apr
2013
10 Apr
'13
6:18 p.m.
On Wed, Apr 10, 2013 at 08:04:22PM +0200, Daniel Lezcano wrote:
On 04/10/2013 06:55 PM, Andrew Lunn wrote:
+/**
- cpuidle_register: registers the driver and the cpu devices with the
- coupled_cpus passed as parameter. This function is used for all common
- initialization pattern there are in the arch specific drivers. The
- devices is globally defined in this file.
- @drv : a valid pointer to a struct cpuidle_driver
- @coupled_cpus: a cpumask for the coupled states
- Returns 0 on success, < 0 otherwise
- */
+int cpuidle_register(struct cpuidle_driver *drv,
const struct cpumask *const coupled_cpus)+{
- int ret, cpu;
- struct cpuidle_device *device;
- ret = cpuidle_register_driver(drv);
- if (ret) {
printk(KERN_ERR "failed to register cpuidle driver\n");pr_err()
Ok.
return ret;- }
- for_each_possible_cpu(cpu) {
device = &per_cpu(cpuidle_dev, cpu);device->cpu = cpu;+#ifdef CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED
device->coupled_cpus = *coupled_cpus;+#endif
ret = cpuidle_register_device(device);if (!ret)continue;printk(KERN_ERR "Failed to register cpuidle ""device for cpu%d\n", cpu);pr_err() and don't split the message over two lines, it makes it harder for somebody to find with
grep -r "Failed to register cpuidle device for cpu" *
Ok if the line length is under 80 chars.
Take a closer look at the CodingStyle documents. This is one except to the rule. Such lines can be longer than 80 characters.
Andrew