On Mon, Mar 10, 2014 at 06:17:22PM +0100, Lars-Peter Clausen wrote:
On 03/10/2014 06:05 PM, Charles Keepax wrote:
WRITE_SEQUENCER_CTRL_3, seems we should add that in since it is required for that 5102 boot stuff. Slightly confused as to how that ever worked without the register being readable, but guess it has been a while since I have fired up 5102 on mainline.
Presumably this change triggered it:
http://git.kernel.org/cgit/linux/kernel/git/broonie/regmap.git/commit/?h=top...
Indeed. Now that I think about it there's another bug lying underneath too - the register isn't marked as volatile so it'll only actually be being read on first read. For some reason that check is only done on probe so it's got no impact but it seems it's asking for future breakage.