On Mon, Aug 25, 2014 at 12:57:40PM -0700, David Miller wrote:
From: Mark Brown broonie@kernel.org
From: Mark Brown broonie@linaro.org
struct rds_sock is rather large ausing the following warning in an ARM allmodconfig:
net/rds/iw_rdma.c:200:1: warning: the frame size of 1056 bytes is larger than 1024 bytes [-Wframe-larger-than=]
Fix this by dynamically allocating struct rds_sock in rds_iw_update_cm_id instead of allocating it on the stack.
Signed-off-by: Mark Brown broonie@linaro.org
I'd like you to fix this differently. Creating pseudo instances of objects, and partially initializing it, just to satisfy an interface is always a really bad sign.
Create a key structure argument for rds_iw_get_device() and initialize that and pass it in instead, update the other caller similarly.
I agree that the existing code looks like it could be improved even more but please bear in mind that I'm just looking for a clean build (we've got less than 20 warnings in allmodconfig including staging at the minute) rather than actively working on this code in particular - I've no ability to do more than build testing here.