Re: [PATCH] pinctrl: Quiet logging about missing DT nodes when not using DT

On Thu, 2014-01-30 at 18:57 +0000, Mark Brown wrote:

From: Mark Brown broonie@linaro.org

On systems which were not booted using DT it is entirely unsurprising that device nodes don't have any DT information and this is going to happen for every single device in the system. Make pinctrl be less chatty about this situation by only logging in the case where we have DT.

trivia:

diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c

[]

@@ -186,7 +186,9 @@ int pinctrl_dt_to_map(struct pinctrl *p) /* CONFIG_OF enabled, p->dev not instantiated from DT */ if (!np) {

• dev_dbg(p->dev, "no of_node; not parsing pinctrl DT\n");
  

• if (of_have_populated_dt())
  

• 	dev_dbg(p->dev,
  

• 		"no of_node; not parsing pinctrl DT\n");
  

There are 80 columns. It's OK to use them all.

dev_dbg(p->dev, "no of_node; not parsing pinctrl DT\n");