Re: [PATCH 2/6] PM / OPP: restructure _of_init_opp_table_v2()

On 11-08-15, 12:27, Viresh Kumar wrote:

diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c index 1daaa1a418a2..be3356a3a452 100644 --- a/drivers/base/power/opp.c +++ b/drivers/base/power/opp.c @@ -1292,14 +1292,18 @@ static int _of_init_opp_table_v2(struct device *dev, } /* There should be one of more OPP defined */

• if (WARN_ON(!count))

• if (WARN_ON(!count)) {

• ret = -ENOENT;
  

  goto out;
• }

if (!ret) { if (!dev_opp) { dev_opp = _find_device_opp(dev);

• 	if (WARN_ON(!dev_opp))
  

• 	if (WARN_ON(!dev_opp)) {
  

Dan also reported that !dev_opp isn't enough as we need to use IS_ERR here.

We have got enough updates here, let me resend the series again to get more reviews on proper patches.