Re: [PATCH 1/2] cpustat: use accessor functions for get/set/add

On Fri, 2013-02-22 at 14:38 +0100, Frederic Weisbecker wrote:

Looks good, just a minor neat:

On Thu, Feb 21, 2013 at 09:56:43PM -0800, Kevin Hilman wrote:

...

diff --git a/include/linux/kernel_stat.h b/include/linux/kernel_stat.h index 66b7078..df8ad75 100644 --- a/include/linux/kernel_stat.h +++ b/include/linux/kernel_stat.h @@ -32,7 +32,7 @@ enum cpu_usage_stat { }; struct kernel_cpustat {

• u64 cpustat[NR_STATS];

• u64 _cpustat[NR_STATS];

Why do you need the underscore?

To make sure there's nobody still referencing the data directly instead of through the accessors.